Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/relay factory #56

Merged
merged 4 commits into from
Apr 30, 2020
Merged

Feature/relay factory #56

merged 4 commits into from
Apr 30, 2020

Conversation

vvval
Copy link

@vvval vvval commented Apr 21, 2020

No description provided.

@vvval vvval requested review from rustatian and wolfy-j April 21, 2020 17:09
@vvval
Copy link
Author

vvval commented Apr 21, 2020

Resolves #39

@codecov
Copy link

codecov bot commented Apr 21, 2020 •
edited
Loading

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   64.90%   64.90%           
=======================================
  Files           7        7           
  Lines         208      208           
=======================================
  Hits          135      135           
  Misses         42       42           
  Partials       31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4576593...f394ceb. Read the comment docs.

rustatian
rustatian approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@rustatian rustatian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rustatian
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 30, 2020

Build succeeded:

@bors bors bot merged commit e749a08 into master Apr 30, 2020
@bors bors bot deleted the feature/relay-factory branch April 30, 2020 11:45
@rustatian rustatian linked an issue May 4, 2020 that may be closed by this pull request
RelayInterface should offer a static factory method #39
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustatian rustatian rustatian approved these changes

@wolfy-j wolfy-j Awaiting requested review from wolfy-j

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RelayInterface should offer a static factory method
2 participants
@vvval @rustatian